Avoid to fail when building RHEL8.7 AMI with kernel not supported by Lustre #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2441 +/- ##
========================================
Coverage 70.34% 70.34%
========================================
Files 13 13
Lines 1851 1851
========================================
Hits 1302 1302
Misses 549 549
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
enrico-usai
force-pushed
the
wip/rhel8-lustre
branch
3 times, most recently
from
8df6f60 to
8b66853
Compare
…Lustre The latest RHEL8.7 kernel 4.18.0-425.19.2.el8_7 introduced a kABI regression, causing Lustre to re-release the client compiled for this latest version. This change means that this same client will not modprobe for kernel 4.18.0-425.13.1.el8_7. With this patch we're skipping Lustre installation and printing a warning in the log, like we did for 4.18.0-425.3.1.el8 that has a similar issue. ### Tests EC2: ``` # RHEL-8.7.0_HVM-20230330-x86_64-56-Hourly2-GP2 in eu-west-1 # with kernel 4.18.0-425.13.1.el8_7 export KITCHEN_RHEL8_AMI=ami-0fa2f7b35eeb82b7a bash kitchen.ec2.sh environment-install test lustre-rhel8 ``` Before the patch: this test was failing on converge phase, After the patch: converge is passing and printing the following WARN message: ``` WARN: FSx for Lustre is not supported in kernel version 4.18.0-425.13.1.el8_7.x86_64 of RHEL 8.7, please update the kernel version ``` Docker: ``` bash kitchen.docker.sh environment-install test lustre-rhel8 ``` This test passes because in docker we have RHEL 8.8 with a fake value for kernel version and we're skipping modprobe command. Use 477 version in the kernel release test variable to match 8.8 kernel version available on docker. ### References * 4.18.0-425.3.1 issue: https://access.redhat.com/solutions/6985596 * 4.18.0-425.19.2 issue: openzfs/zfs#14724 Signed-off-by: Enrico Usai <usai@amazon.com>
enrico-usai
force-pushed
the
wip/rhel8-lustre
branch
from
8b66853 to
3dd39d6
Compare
We're overriding the kernel_release variable on docker because it does not have the same format of EC2. Adding the "fake-value" word in the kernel version simplifies debugging on docker. Signed-off-by: Enrico Usai <usai@amazon.com>
enrico-usai
force-pushed
the
wip/rhel8-lustre
branch
from
3dd39d6 to
3abb748
Compare
dreambeyondorange
approved these changes
Aug 31, 2023
lukeseawalker
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The latest RHEL8.7 kernel 4.18.0-425.19.2.el8_7 introduced a kABI regression,
causing Lustre to re-release the client compiled for this latest version.
This change means that this same client will not modprobe for kernel 4.18.0-425.13.1.el8_7.
With this patch we're skipping Lustre installation and printing a warning in the log,
like we did for 4.18.0-425.3.1.el8 that has a similar issue.
Tests
EC2:
Before the patch: this test was failing on converge phase,
After the patch: converge is passing and printing the following WARN message:
Docker:
This test passes because in docker we have RHEL 8.8 with a fake value for kernel version and we're skipping modprobe command.
Use 477 version in the kernel release test variable to match 8.8 kernel version available on docker.
We're overriding the kernel_release variable on docker because it does not have the same format of EC2.
Adding the "fake-value" word in the kernel version simplifies debugging on docker.
References